Skip to content

src: store pointer to Environment on DestroyParam

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/fix-weak-callback into master

To avoid a potential segfault when inside WeakCallback, store a reference to Environment inside DestroyParam. (Talk to @hashseed for more info.)

Without this patch, node will fail on one of our tests when run as node --stress-compaction test/parallel/test-async-hooks-recursive-stack.js.

Co-authored-by: Yang Guo yangguo@chromium.org Co-authored-by: Michaël Zasso targos@protonmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports