Skip to content

child_process: swallow errors in internal communication

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/fix-socket-list-epipe into master

Much like with NODE_HANDLE_ACK, the internal protocol for communication about the sent socket should not expose its errors to the users when those async calls are not initiated by them. This also switches to use the internal _send api instead of the public one which performs a bunch of args validation which is not necessary in core code.

This will fix the currently reasonably frequent flakes on Windows in relation to child_process. It might also make it possible to remove some of our special case handling of Windows in our tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports