Skip to content

test: make url-util-format engine agnostic

Rodrigo Muino Tomonari requested to merge github/fork/Trott/homeward-11 into master

test-util-format checks the message of an error that is generated by the JavaScript engine. Error messages that change in the underlying JavaScript engine should not be breaking changes in Node.js and therefore should not cause tests to fail. Remove the message check and replace it with a check of the type of the Error object along with the absence of a code property. (If a code property were present, it would indicate that the error was coming from Node.js rather than the JavaScript engine.)

This also makes this test usable without modification in the ChakraCore fork of Node.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports