Skip to content

http2: fix GC issue & typos

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/patch-http2-fixes into master

There are two commits here:

  1. It's hypothetically (and with certain V8 flags) possible for the session to be garbage collected before all the streams are. In that case, trying to remove the stream from the session will lead to a SEGFAULT due to attempting to access no longer valid memory. Fix this by unsetting the session on any streams still around when destroying.

  2. fix node_http2.cc comment typos

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports