Skip to content

http: fix request with option timeout and agent

Rodrigo Muino Tomonari requested to merge github/fork/killagu/fix-timeout into master

When request with both timeout and agent, timeout not work. This patch will fix it, socket timeout will set to request timeout before socket is connected, and socket timeout will reset to agent timeout after response end.

Update agent doc, add timeout option.

Fixes: https://github.com/nodejs/node/issues/21185

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports