Skip to content

build: fix cctest build failure in Windows

Rodrigo Muino Tomonari requested to merge github/fork/yhwang/fix-windows-undefined-symbols into master

cctest needs to access some internal APIs in node core. Putting node_lib_target_name as dependency would causes linking error when node_lib is built as shared lib in Windows. The reason being is those internal APIs don't have __declspec(dllexport). For cctest we still need to specify individual obj files and link them instead of node_lib. In Windows, changes of the dependencies in libraries trigger the cctest to rebuild. However, in Linux platforms, it doesn't work. Instead, need to put obj dependencies into sources.

Signed-off-by: Yihong Wang yh.wang@ibm.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports