Skip to content

test: remove the third string literal argument from assert.strictEqual()

Rodrigo Muino Tomonari requested to merge github/fork/kevintab95/remove-string-literal-from-assertion into master

Third string literal argument in assert.strictEqual() needs to be removed. Otherwise, on AssertionError it would not display the values that failed the check -- this hinders debugging. The string literals are added as comments above the check.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows [commit guidelines]

Merge request reports