Skip to content

doc: restore documentation for two error codes

Rodrigo Muino Tomonari requested to merge github/fork/ChALkeR/doc-errcodes-revert-missing-removal into master

ERR_HTTP2_ERROR and ERR_UNKNOWN_BUILTIN_MODULE error codes documentation seem to have been accidentally removed in commit 1cdb41f2 (pull request #15160).

This reverts that removal, restoring the documentation for those two error codes.

Those error codes are used from lib/ folder.

This is a part of the fixes hinted by #21470, which includes some tests for error codes usage and documentation and enforces a stricter format.

I split this into a separate commit/PR as this should be easy to land (and backport if needed), and some of the other fixes are more heavy and/or controversial.

Refs: https://github.com/nodejs/node/pull/21470, https://github.com/nodejs/node/issues/21440, https://github.com/nodejs/node/pull/15160

Tests are not included — #21470 does that.

Exact usage locations: https://github.com/nodejs/node/blob/a40e06233eeb657a38373c0f1ff03a32a310b998/lib/internal/bootstrap/loaders.js#L146-L150 https://github.com/nodejs/node/blob/a40e06233eeb657a38373c0f1ff03a32a310b998/lib/internal/http2/util.js#L471-L478

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports