Skip to content

module: use compileFunction over Module.wrap

Rodrigo Muino Tomonari requested to merge github/fork/ryzokuken/module-cjs-compile into master

Use vm.compileFunction (which is a binding for v8::CompileFunctionInContext) instead of Module.wrap internally in Module._compile for the cjs loader.

Fixes: https://github.com/nodejs/node/issues/17396

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @nodejs/modules-active-members @hashseed @addaleax

Merge request reports