Skip to content

assert: multiple improvements

Rodrigo Muino Tomonari requested to merge github/fork/BridgeAR/improve-assert-things into master

I am going to split this into smaller commits. Therefore it is WIP.

The following changes are in here:

  • Switched + / - | red / green (by request). It does seem to feel a bit more natural this way. Let's hope that most people agree with this.
  • Short primitives do not use the diff anymore (by request). Especially short numbers can be read well like 1 !== 2.
  • Improved error descriptions. It was not really clear how things worked. It should now be clear what everything is about.
  • Added a position indicator for single lines that fit into the tty.
  • Simple assert will now rarely bail out when checking the call site and the output got improved.
  • Some performance optimizations
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports