Skip to content

[v10.x] deps: update V8 to 6.8

Rodrigo Muino Tomonari requested to merge github/fork/psmarshall/v8-api-combat-6.8 into v10.x-staging
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Here is the ABI compat patch for v8 6.8 (to make it look like 6.7, which is currently in Node 10).

Here is the result of git diff master -- deps/v8/include with this patch: https://gist.github.com/psmarshall/75376dbb81dbfbf17cfc47d62cb2e80b

One thing to fix: I guess we also need to get rid of the kRead field from the PageAllocator::Permission enum in v8-platform.h - that is going to be a bit more involved. Could that break an embedder?

For now, I built this on top of https://github.com/nodejs/node/pull/21079.

@addaleax @targos @hashseed

Merge request reports