Skip to content

[v8.x backport] http: do not rely on the 'agentRemove' event

Rodrigo Muino Tomonari requested to merge github/fork/lpinca/backport/20786 into v8.x-staging

Do not use the 'agentRemove' event to null socket._httpMessage as that event is public and can be used to not keep a request in the agent.

PR-URL: https://github.com/nodejs/node/pull/20786 Fixes: https://github.com/nodejs/node/issues/20690 Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Trivikram Kamat trivikr.dev@gmail.com Reviewed-By: Anatoli Papirovski apapirovski@mac.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports