Skip to content

test: extract globals & use in test-abort-backtrace

Rodrigo Muino Tomonari requested to merge github/fork/jeromecovington/test-common-globals into master

It was suggested that extracting globals from test/common/index.js so that it can be required individually will pare down test dependencies could ultimately improve test performance.

See discussion on this issue, especially the linked comment: https://github.com/nodejs/node/issues/20128#issuecomment-389933546

This diff demonstrates first steps towards not needing to require test/common/index.js in all tests.

If enough/all the dependent tests were refactored, benchmarks could be shown. Although, it seems sensible to break those forthcoming refactors into separate, reasonably small PRs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports