Skip to content

benchmark: remove arrays benchmark

Rodrigo Muino Tomonari requested to merge github/fork/psmarshall/benchmarks-arrays into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

I'd like to suggest removing these benchmarks - here's a few reasons why:

  1. These benchmarks have been around for a long time. I think their original purpose was to measure performance of these typed arrays before they were in V8 (possibly, they were implemented in Node itself at some point?). V8 itself has benchmarks which cover the performance of typed arrays which we actively monitor.
  2. These benchmarks don't exercise Node itself as far as I can tell, they are essentially a benchmark of the JS engine being used. That could be a potentially useful thing to have, but I'd argue that those benchmarks would be better suited living outside of Node, or at least separately to the main actual 'Node' benchmarks.
  3. This benchmark also tests Buffer, which is interesting to benchmark from a Node point of view, but has it's own benchmark suite under benchmarks/buffer, so there is no need to duplicate it here.

Merge request reports