Skip to content

util: Fix number format for `pad`

Rodrigo Muino Tomonari requested to merge master-21906 into master

Created by: ghost

pad is now using toString(10), actually we don't need to do this. As for https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/toString, toString(N) is a radix converter, which isn't proper here for time conversion.

PS：Since this is a private function with n a decimal number, so I suspect the code writer wanted to use toString(10) to convert a number to a two-digit number, and if the number < 10, a 0 is automatically added before the number itself. Obveriously this isn't a right way. Though the final answer is right.

Hope you all take what I mean.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports