Skip to content

http2: release request()'s "connect" event listener after it runs

Rodrigo Muino Tomonari requested to merge github/fork/ide/http2-onconnect into master

The Http2Session#request() method internally listens to the "connect" event if the session has not yet established a connection so that the actual request can be sent after the connection has been established.

This commit removes the event listener after it runs and carries out the request and is no longer needed. In practice this shouldn't affect the behavior of the session object since the "connect" event fires only once anyway, but removing the listener releases its references. The rest of this class subscribes to the "connect" event with once instead of on as well.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports

Loading