Skip to content

src: add proper MemoryInfoName to wrappers

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/wrap-node-name into master
  • Use camel case names for memory retainers inherited from AsyncWrap instead of their provider names (which are all in upper case)
  • Assign class names to wraps so that they appear in the heap snapshot as nodes with class names as node names. Previously some nodes are named with reference names, which are supposed to be edge names instead.

Before (in DevTools): screen shot 2018-07-22 at 9 13 32 am

After: screen shot 2018-07-22 at 9 11 46 am

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports