Skip to content

fs: begin trial fs.(promises.)?(read|write|f?truncate) with bigint fo…

Rodrigo Muino Tomonari requested to merge github/fork/ZaneHannanAU/master into master

…r (position|len)

Notable internal changes. Currently also fails tests.

For now I'll ask for help with it... /cc @nodejs/fs

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

node: make passes; but running the compiled ./node causes a core dump:

$ ./node 
> ./node[27732]: ../src/node_file.cc:1631:void node::fs::Read(const v8::FunctionCallbackInfo<v8::Value>&): Assertion `args[4]->IsBigInt()' failed.
 1: 0x8b9220 node::Abort() [./node]
 2: 0x8b92f5  [./node]
 3: 0x8fbb12  [./node]
 4: 0xb5d809  [./node]
 5: 0xb5e6a4 v8::internal::Builtin_HandleApiCall(int, v8::internal::Object**, v8::internal::Isolate*) [./node]
 6: 0x298995a5c01d 
Aborted (core dumped)
$

Merge request reports