Skip to content

src: yield empty maybes for failed AsyncWrap::MakeCallback calls

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/async-wrap-makecallback-empty into master

Use an empty MaybeLocal<Value> as the return value for AsyncWrap::MakeCallback() if an exception occurred, regardless of MakeCallback depth.

Unfortunately, the public API can not make this switch without a breaking change (and possibly some kind of deprecation/renaming).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports