Skip to content

src: fix integer overflow in GetNow

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/fix-integer-overflow-timers into master

Well, that was stupid... This check used to be for 0xfffffff which was wrong (one f too few) so that got fixed, but that change was made based on it being cast to a uint32_t (2**32-1) rather than the correct int32_t. Of course, Integer::New just happily accepted it despite not actually being able to handle it. Fun stuff...

Fixes https://github.com/nodejs/node/issues/22149

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports