Skip to content

doc: require two approvals to land changes

Rodrigo Muino Tomonari requested to merge github/fork/Trott/simplify-approval into master

First in a series that will hopefully streamline/simplify our policies. I don't want this to slip in unnoticed and it's a significant procedural change being proposed, so: @nodejs/collaborators

Currently, changes require approval by one Collaborator in most cases. However there are situations where two approvals are required. For example, breaking changes require two approvals from TSC members. And fast-tracking a request requires two approvals.

Additionally, although only one approval is strictly required, in practice, we nearly always seek a second approval when there is only one.

Lastly, concerns have been raised about (perhaps unintentionally) gaming the one-approval system by suggesting a change to someone else, and then approving that change when the user submits a pull request. This resolves (or at least mitigates) that concern.

Refs: https://github.com/nodejs/node/issues/19564

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports