Skip to content

deps: fix CRLF in text file not present in upstream

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/use-lf-in-v8 into master

deps/v8/third_party/jinja2/LICENSE is not in upstream v8, and contains CRLF, which is in conflict with deps/v8/.gitattributes which sets all text files to use LF. This has caused failures in CI workers with older versions of Git. This patch manually fixes up the file to use LF to resolve the conflict.

The file has already been fixed in upstream jinja2, which is pull into our repo when we update V8 so it should be fixed the next time we update V8.

Refs: https://github.com/nodejs/build/issues/1443 Refs: https://github.com/nodejs/reliability/issues/12 Refs: https://github.com/nodejs/build/issues/1453 Refs: https://chromium-review.googlesource.com/c/993812/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports