Skip to content

test: remove isGlibc from common

Rodrigo Muino Tomonari requested to merge github/fork/jasnell/test-no-common-isglibc into master

The common.isGlibc() function is called exactly once from only one test. There's no reason for it to be in require('../common') at the current time. If it ends up needing to be used by multiple tests, it can easily be moved into it's own common sub-module (e.g. require('../common/isglibc') ... for now tho, just move it into the one test that uses it and simplify the implementation a bit to remove unnecessary caching.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports