Skip to content

crypto: fix incorrect use of INT_MAX in validation

Rodrigo Muino Tomonari requested to merge github/fork/tniessen/crypto-fix-incorrect-use-of-intmax into master

The native crypto module doesn't export INT_MAX, so all occurrences in the JavaScript layer evaluated to undefined. This change removes all such occurrences and replaces validateInt32 with validateUint32 since the native layer assumes uint32_t anyway.

The alternative would be to use the constant from the constants module, but that would be pointless as far as I can tell. If someone sees a reason to keep using INT_MAX here, I will gladly change it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports