Skip to content

tracing: remove shutdown-on-signal

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/fix-22528 into master

This feature cannot be reasonably implemented this way without inherently being susceptible to race conditions that lead to hangs, crashes, etc.

What’s more, implementing this for some signals only (and it can only be implemented for some signals at all) may lead to the impression that it is a guaranteed feature, when really consumers of the tracing output need to be able to handle abrupt ends meaningfully.

Fixes: https://github.com/nodejs/node/issues/14802 Fixes: https://github.com/nodejs/node/issues/22528

@nodejs/diagnostics @jasnell @BridgeAR

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports