Skip to content

crypto: deprecate digest == null in PBKDF2

Rodrigo Muino Tomonari requested to merge github/fork/tniessen/crypto-fix-pbkdf2-behavior-for-digest-null into master

I assume that permitting digest === null was unintentional when digest === undefined was deprecated since their behavior was equivalent. The sha1 default for digest === null has somehow made it through refactoring of the PBKDF2 module multiple times, even though digest === undefined has been EOL for some time now.

This change deprecates setting digest to null so we can fix the behavior in Node.js 12 or so.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports