Skip to content

http2: do not falsely emit 'aborted' on push

Rodrigo Muino Tomonari requested to merge github/fork/apapirovski/fix-http2-push-aborted into master

A push stream should have its writable side closed upon receipt, to avoid emitting the 'aborted' event when the readable side is closed.

(As far as I can tell this has been an issue as long as http2 has been around.)

Fixes: https://github.com/nodejs/node/issues/22851

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports