Skip to content

win,msi: install Boxstarter from elevated shell

Rodrigo Muino Tomonari requested to merge github/fork/JaneaSystems/joaocgreis-I9J-msi-tools-2 into master

This fixes the issue described in https://github.com/nodejs/node/pull/22645#issuecomment-422696809 (cc @targos).

Boxstarter asks for elevation to install packages, but not to install Boxstarter itself. If Boxstarter is already installed, the command succeeds with or without elevation. This PR changes the batch file to run all the commands from an elevated PowerShell.

LTS and semver: This is a bug fix for https://github.com/nodejs/node/pull/22645, which is currently only in master. That PR is semver-minor without a strong case for backporting, so this one should not be backported as well even if this is semver-patch.

cc @nodejs/platform-windows @richardlau

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports