Skip to content

doc: simplify pull request wait time to 60 hours

Rodrigo Muino Tomonari requested to merge github/fork/Trott/60 into master

Trying to see if we can get consensus on a compromise on the rule simplification to 60 hours.

Prior art:

48 hour PR: https://github.com/nodejs/node/pull/23082 72 hour PR: https://github.com/nodejs/node/pull/22275

Currently, we have a 48/72 rule for how many hours a pull request should be left open at a minimum. Unfortunately, whether a pull request should be left open for 48 or 72 hours is often unclear. The 72 hours is required if it is a weekend. If I open a pull request on a Friday morning, does it need to stay open 48 hours or 72 or something in between? Does it matter if I'm in one time zone or another?

Pull requests used to require a single approval but now require two approvals unless they've been open for a week. Given this, it seems like we can simplify the wait time rule to be just 60 hours.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports