Skip to content

crypto: set `DEFAULT_ENCODING` property to non-enumerable

Rodrigo Muino Tomonari requested to merge github/fork/aduh95/remove-crypto-warnings into master

Since it is a deprecated API, a deprecation warning is printed when loading crypto module from ESM. Making it non enumerable removes the deprecation warning and makes the API non-available to named imports.

Fixes: https://github.com/nodejs/node/issues/23203

The Credentials API was already removed by https://github.com/nodejs/node/pull/21153.

It is a breaking change, but IMHO it should be integrated to Node 11 before it's released as it is a minor semver change.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports