Skip to content

benchmark: add common.binding()

Rodrigo Muino Tomonari requested to merge github/fork/cjihrig/benchmark-bindings into master

Recently, process.binding() was replaced with internalBinding(). However, internalBinding() is not available on older builds of Node, which are often used for benchmarking purposes. This commit adds a common.binding() to the benchmarks to work around the issue. Hopefully, this can be removed in the not too distant future.

Fixes: https://github.com/nodejs/node/issues/23436

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports