Skip to content

tls: prevent multiple connection errors

Rodrigo Muino Tomonari requested to merge github/fork/cjihrig/23631 into master

onConnectEnd(), which is called by TLSSocket, has a guard to prevent being called multiple times, but it does not prevent the OpenSSL error handler from being called, leading to multiple error events. This commit adds that piece of missing logic.

Fixes: https://github.com/nodejs/node/issues/23631

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-pull-request/17937/

Merge request reports