Skip to content

http2: add Http2Stream.bufferSize

Rodrigo Muino Tomonari requested to merge github/fork/oyyd/http2-stream-buffersize into master

This commit adds bufferSize for Http2Stream.

Refs: #21631 (closed)

/cc @jasnell @addaleax @apapirovski

From the code, I believe the writeQueueSize in http2 module could represent the kLastWriteQueueSize in net module: https://github.com/nodejs/node/blob/deaddd212c499c7ff88d20034753b5f3f00d5153/lib/net.js#L518 and the tests following this PR seems okay. Can you help to confirm that?

BTW, we can add Http2Session.bufferSize basing on this which is what #21631 (closed) exactly requested.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports