Skip to content

src: refactor out some warnings from `FillStatsArray` and `node_file.h`

Rodrigo Muino Tomonari requested to merge github/fork/refack/GSL into master

#### adds a the Guideline Support Library to /deps/:

src: refactor out warnings from FillStatsArray

  • move FillStatsArray to node_file.h minimize number of template instantions
  • change inline to constexpr
  • change MACRO consts to constexpr
  • correct polymorphic conversion from uv_timespec_t
  • DRY FillGlobalStatsArray
  • change FillGlobalStatsArray signature to have one less default arg
  • reduce some includes

src: clean clang-tidy errors in node_file.h

  • fix bug with non virtual dtor
  • delete move constructors
  • default initialize all members
  • discard unneeded return values
  • const some possibles
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports