Skip to content

module: allow passing a directory to createRequireFromPath

Rodrigo Muino Tomonari requested to merge github/fork/gillesdemey/fix/createRequireFromPath into master

Fixes: https://github.com/nodejs/node/issues/23710

I still need to update the documentation for this change, I'm not quite sure if we should update the documentation to encourage users to pass a directory or do we prefer a file path?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports