Skip to content

deps: cherry-pick d9fbfeb from upstream V8

Rodrigo Muino Tomonari requested to merge github/fork/kjin/v8-float-d9fbfeb into master

Original commit message:

inspector: return [[StableObjectId]] as internal property

This property might be useful for fast '===' check.

R=dgozman@chromium.org,yangguo@chromium.org

Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56095}

This commit allows us to determine the structure of circular objects through inspector (before, there was no surefire way to know if you entered an infinite loop while recursively iterating through an object's properties, because each object returned through the inspector was given a unique, monotonically increasing ID.

Hopefully, this change can make it into v10 and v11 at the very least.

cc/ @ak239 @ofrobots

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports