Skip to content

src: fix CreatePlatform header param mismatch

Rodrigo Muino Tomonari requested to merge github/fork/codebytere/fix-header into master

This PR forward-declares node::tracing::TracingController instead of v8::TracingController to correct for the existing mismatch in parameters between MultiIsolatePlatform CreatePlatform in the header and impl. It can cause inconsistencies in exported symbols.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports