Skip to content

src: fix fully-static and large-pages combination

Rodrigo Muino Tomonari requested to merge github/fork/suresh-srinivas/fully-static-large-pages into master

Fixes: https://github.com/nodejs/node/issues/23906 Refs: https://github.com/nodejs/node/pull/22079

This change to ld.implicit.script moves libc static code to .lpstub area and avoids the issue detailed in 23906

Quick performance comparision on web-tooling shows 3% improvement for the combination over fully-static

                                 fully-static-lp   fully-static
  cycles                       376,235,487,455  390,007,877,315
  instructions                 700,341,146,973  714,773,201,182
  itlb_misses_walk_completed        20,654,246       28,908,381
  itlb_misses_walk_completed_4k     19,884,666       28,865,118
  itlb_misses_walk_completed_2m_4m     769,391           43,251
  Score                                   9.13             8.86
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports