Skip to content

url: make the context non-enumerable

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/url-no-enum into master

At the moment we expose the context as a normal property on the URL which makes them enumerable and considered by assert libraries even though the context carries path-dependent information that do not affect the equivalence of these objects. This patch fixes it in a minimal manner by marking the context non-enumerable as making it full private would require more refactoring and can be done in a bigger patch later.

Refs: https://github.com/nodejs/node/issues/24211

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports