Skip to content

src, test: fix V8 compiler warnings

Rodrigo Muino Tomonari requested to merge github/fork/danbev/v8_compiler_warnings into master

This pull request follows up on https://github.com/nodejs/node/pull/24060 and attempts to fix all the remaining v8 warnings regarding Set/Get.

There is currently one warning still being generated from [src/node.cc](https://github.com/nodejs/node/commit/a52528321fb5f493ed70b981900e4bca5aa109e9#diff-cd53544f44aab2c697bcd7b6a57f23ccR675-677)

I've left a comment in the code as I was not sure how to get the correct context. Hopefully someone can help out and advise on this.

The commits are currently separate for each C++ source file but can be squashed unless anyone objects.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports