src: remove pushValueToArray and setupProcessObject (!24264) · Merge requests · Rodrigo Test / Test Group-nodejs / node · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/remove-push into master Nov 09, 2018

This PR removes

pushValueToArray
NODE_PUSH_VAL_TO_ARRAY_MAX
env->env->push_values_to_array_function()

In favor of the new V8 C++ API that constructs an Array from a C++ array directly.

Also removes setupProcessObject since by now it is only doing the push_values_to_array_function setup. Also added a test for os.cpus() values.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines