Skip to content

async_hooks: add HandleScopes to C++ embedder/addon API

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/async-handle-scopes into master

Add HandleScopes to the public C++ API for embedders/addons, since these methods create V8 handles that should not leak into the outer scopes.

In particular, for some of the methods it was not clear from the function signatures that these functions previously needed to be invoked with a HandleScope.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports