Skip to content

internal,buffer: Use dataview for numerical readwrite calls

Rodrigo Muino Tomonari requested to merge github/fork/ZaneHannanAU/buffer-internal-dataview into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Note that although documentation changes are not included due to no functional changes; I am willing to add to them; though adding them will require a notable change in the initial commit title as it is currently 70 characters. I am able to perform them; but I would like to leave it be for the effort today.

This commit should incur a benchmark; as it is primarily focused on attempting to increase the speed of the numerical Buffer.read and Buffer.write functions. Further optimisations such as use of top-level numerical constants should be considered for this. Added

There may be some issues when writing larger integers due to how larger integers are handled (truncation) but require tests to check for; but currently do not appear to be effected. Added for insurance

Merge request reports