Skip to content

test: add a test to make sure the modules can be required independently

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/test-deps into master

The first patch comes from https://github.com/nodejs/node/pull/24396

So, I am not entirely sure if it's worth adding a test that launches ~75 child processes just to make sure we have a cleaner dependency graph in the internal modules..so just open this to see what others think.

test: add a test to make sure the modules can be required

This patch adds a test that makes sure all the modules (internal or not) can be independently required - that is, when there is circular dependency, one module does not rely on another module being loaded first to initialize, instead it should lazily load that dependency after initialization.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports