Skip to content

test: remove test-timers-first-fire

Rodrigo Muino Tomonari requested to merge github/fork/JaneaSystems/joaocgreis-F8K-remove-timers-first-fire into master

According to the documentation of setTimeout:

It is important to note that your callback will probably not be called in exactly delay milliseconds - io.js makes no guarantees about the exact timing of when the callback will fire, nor of the ordering things will fire in. The callback will be called as close as possible to the time specified.

Hence, this test is inconsistent as it is and should be removed.

This test is flaky on all platforms, because setTimeout uses a time base set before the call to hrtime. This is specially relevant on Windows, where this accumulates with another issue in libuv (libuv/libuv#385) making this test fail very frequently.

cc @piscisaureus

Merge request reports