Skip to content

test: check invalid argument error for option

Rodrigo Muino Tomonari requested to merge github/fork/nanomosfet/update-test-textdecoder into master

this adds a test for the validateArguments function in TextDecoder

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

As another note I would like to test the function makeTextDecoderJS in encoding.js but I do not know how to force hasIntl to be false without rebuilding node with the option --without-intl. Is there a way to do this at runtime? (Maybe it could be providing a icu-data-dir that has it disabled? I just don't know what that file would look like if that is the case)

If anyone knows a way to set hasIntl to off let me know because I can just include those tests and get the coverage of encoding.js up even more!

Merge request reports