Skip to content

[8.x] assert: revert breaking change

Rodrigo Muino Tomonari requested to merge github/fork/BridgeAR/revert-major-change into v8.x-staging

It was not intended to change the assert.doesNotThrow() message with https://github.com/nodejs/node/pull/23223. This reverts the breaking behavior to the one before.

Refs: https://github.com/nodejs/node/pull/23223#issuecomment-443493425

I guess it won't hurt much if we keep this change in 8.x but it was not meant to be in 8 and therefore I opened this revert.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports