Skip to content

build: fix check-xz for platforms defaulting to sh

Rodrigo Muino Tomonari requested to merge github/fork/rvagg/rvagg/makefile-xz-check-fix into master

5e80a9a1 introduced check-xz, using [[ .. ]] syntax, but this is a bash builtin and some platforms default to sh when doing $(shell ...) in Makefiles.

Fix is to make it sh friendly.

Ref: https://github.com/nodejs/node/pull/24551

I'm not sure why this didn't show up in test builds during the preparation of #24551, but it's broken on the ARM cross compilers and ppcle-ubuntu1404 because of this (I haven't figured out why those platforms, and passing SHELL=/bin/bash doesn't help at all). See https://ci-release.nodejs.org/job/iojs+release/4008/. Best route is to make it work on all platforms anyway so users don't get caught by this.

It's working as expected with this commit: https://ci-release.nodejs.org/job/iojs+release/4013/ coming out @ https://nodejs.org/download/test/v12.0.0-test201812040ba0e0fd89/ (still building but only early failure is AIX as expected, it needs SKIP_XZ).

Merge request reports