Skip to content

test: verify input flags

Rodrigo Muino Tomonari requested to merge github/fork/BridgeAR/check-flags into master

This makes sure all required flags are passed through to the test. If that's not the case an error is thrown to inform the user what flag is missing.

This is especially helpful for people new to Node core who start some tests and don't know why they fail.

I actually intend to improve this further to automatically starting a child_process with the correct flags without any further user interaction necessary (the main process would just end as soon as the child_process is done). In that case we could likely improve our instrumentation as well by stop reading the source in python and to parse the flags there.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports