v8: fix call of its own deprecated API
v8.h contains calls to the deprecated IsCompressible() API causing a deprecated warning for every include of v8.h. The warning is disabled for clang, but GNU compiler chains. Developer builds and ci build logs are filled with pages and pages of warnings at the moment.
@targos @ofrobots @nodejs/v8 can any of you upstream this? The procedure to do so is complex for me, technically and legally. I can do it, but if its trivial for you it would be great if this could be fixed.
Btw, I don't have clang, but I suspect that it may support GCC
pragmas, in which case the easier fix would to be to just change #pragma clang
to #pragma GCC
instead of a new if block for GCC
.
Checklist
-
make -j4 test
(UNIX), orvcbuild test
(Windows) passes -
tests and/or benchmarks are included -
documentation is changed or added -
commit message follows commit guidelines